increase accuracy of power iterations and remove flag normalize_rho
#86
Conversation
There was a problem hiding this comment.
@nHackel: not sure what the problem with the new CI setup is, can you check? The package passed all tests locally.
|
As far as I can see the failing CI is just buildkite. That is CI that runs on GPUs, which wouldnt work for the master anyway atm. |
|
Ah and it fails because the master branch doesnt have the config yet. From a CI standpoint you can feel free ro merge. If this is merged to the master I can also do the merge with the gpuExtension branch. Or do you want to do GPU recos with this? |
|
Right now we want to run recons on the CPU, but we are working on the GPU implementation in parallel, so yes, we do. Ok, then I am just waiting for either @tknopp or you to give me a thumbs up content-wise. |
|
Looks good to me! |
Hi @tknopp,
I increased the default accuracy of the power iterations to ensure the correction step size of FISTA, optISTA, POGM reconstuctions.
I also changed the interface by removing the
normalize_rhoflag and building the power iterations into the default call ofrho, increasing the flexibility to modify the settings of the power iterations as needed.Any chance you could give me a quick thumbs up on this, I would like to go ahead and release this code, as we want to start a bunch of recons with it, and I would prefer not doing this on branch that less permanence than are release.
Many thanks and have a great weekend!